Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pydantic version 2 #372

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Migrate to pydantic version 2 #372

wants to merge 10 commits into from

Conversation

stephen-riggs
Copy link
Contributor

This implements the changes needed for pydantic 2.

In doing this, we also upgrade to sqlalchemy 2, so one change has also been made for that.

Also this removes the procrunner dependency in favour of directly calling subprocess.

Before merging this we need to be able to run MSYS2 or a similar rust-compatible terminal on the microscopes.

Closes #315

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 30 lines in your changes missing coverage. Please review.

Project coverage is 28.34%. Comparing base (0fa51e3) to head (72533df).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   29.12%   28.34%   -0.78%     
==========================================
  Files          70       71       +1     
  Lines        9481    11552    +2071     
  Branches     1747     1883     +136     
==========================================
+ Hits         2761     3274     +513     
- Misses       6618     8122    +1504     
- Partials      102      156      +54     

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Pydantic 2
2 participants